fix: tag compliance checks with surface=v3 - #3092
Open
mgrabina wants to merge 1 commit into
Open
Conversation
The compliance API records which surface a denial came from, but only when the caller sends ?surface=. Without it every denial lands as UNATTRIBUTED and /compliance blocked-stats --surface v3 returns zero.
Mjolnir Security Review
12 PRs reviewed |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
sammdec
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compliance API accepts an optional
?surface=on/check/{address}and records it on every denial, so/compliance blocked-stats --surface v3can split denials by product. This route never sent it, so every denial from the V3 interface lands asUNATTRIBUTED.Reported in #aave-compliance:
--surface v3returned 0 wallets over a full year, while the same query without the filter returned 120, all underUNATTRIBUTED.The param is reporting-only and never affects the verdict. It is unauthenticated and an unrecognised value is ignored rather than rejected, so it cannot block a user.
The V4 Pro side is https://github.com/aave/aave-pro/pull/1393.
Only takes effect from deploy forward. Existing denial rows have no surface recorded and cannot be backfilled.