Fixes 17#206
Open
baranyaib90 wants to merge 9 commits into
Open
Conversation
This reverts commit 442815e. There should not be any use-after-free.
- tighten TCP accept/read/send error handling and non-blocking socket setup - improve logging for dropped TCP clients and response failures - fix UDP bind cleanup - correct address-list buffer bounds checks in dns_poller - refine DNS truncation handling and related response logic
With suggestion to use clangd for IntelliSense purpose.
Also: - breaking long lines for readability - set gcc/clang specific warnings
Some polishing in doh_proxy.c
Details in huge comment in code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Aaron,
finally I raised the pull request:
Take your time.
Best regards,
Balázs
PS: these changes worked fine on my machine for a month ;)