fix: replace deprecated FieldDescriptor.label with is_repeated in proto_utils#1099
Open
Linux2010 wants to merge 2 commits into
Open
fix: replace deprecated FieldDescriptor.label with is_repeated in proto_utils#1099Linux2010 wants to merge 2 commits into
Linux2010 wants to merge 2 commits into
Conversation
…to_utils Use the non-deprecated FieldDescriptor.is_repeated property instead of comparing field.label to LABEL_REPEATED. Remove all TODO comments referencing issue a2aproject#1011. Closes a2aproject#1011 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces deprecated usages of field.label with field.is_repeated (and not field.is_repeated) in src/a2a/utils/proto_utils.py, resolving a TODO regarding protobuf version requirements. There are no review comments to evaluate, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Covers the _recurse_validation path for repeated message fields (e.g. Task.history), which was not previously tested. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🧪 Code Coverage (vs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace all uses of the deprecated
FieldDescriptor.label == LABEL_REPEATEDpattern with the modernFieldDescriptor.is_repeatedproperty insrc/a2a/utils/proto_utils.py.The minimum required protobuf version (
>=5.29.5) already supportsis_repeatedas a stable API, so this change is safe.Changes
field.label == FieldDescriptor.LABEL_REPEATED→field.is_repeated(2 occurrences)field.label != FieldDescriptor.LABEL_REPEATED→not field.is_repeated(1 occurrence)TODOcomments referencing [Task]: Replace deprecatedFieldDescriptor.labelwithis_repeatedinproto_utils#1011Closes #1011