[Fix] Architect mode fails to save plans with EROFS when creating /plans at filesystem root#968
Conversation
The Architect mode custom instructions ended with 'put it in the /plans directory', which models interpreted as an absolute filesystem path, causing 'EROFS: read-only file system, mkdir /plans' when saving plan files. Reword to './plans' and clarify it is relative to the workspace root. Fixes #965
|
No code issues found. See task Verified in context: the Reviewed f2f5e62 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
edelauna
left a comment
There was a problem hiding this comment.
Seems like a simple change.
|
@zoomote resolve conflicts |
|
I saw the mention, but I need your GitHub account linked to Roomote before issue and PR comments can start work here. Link it from Settings -> Linked Accounts and then mention me again. |
Related GitHub Issue
Closes: #965
Description
In Architect mode, Zoo attempted to create a
plansdirectory at the absolute filesystem root (/plans) and failed withEROFS: read-only file system, mkdir '/plans'.Root cause: the Architect mode
customInstructionsinpackages/types/src/mode.tsended with "if you want to save a plan file, put it in the /plans directory". The leading slash leads models to interpret/plansas an absolute path instead of a workspace-relative one, sowrite_to_file/execute_command(mkdir /plans) targeted the real filesystem root.The instruction now reads "put it in the ./plans directory (a directory named "plans" relative to the workspace root, not the absolute filesystem path /plans)". A repo-wide search confirmed this prompt text was the only place an absolute
/planspath was instructed. The 10 affected system-prompt snapshot files were regenerated/updated to match.Test Procedure
pnpm test(full turbo run, forced uncached): all 10 tasks successful — 414 test files / 6786 tests passed in the main package, including the system-prompt snapshot tests that assert the Architect mode instructions.lintandcheck-typesacross all packages: all green.src/core/prompts/__tests__/__snapshots__/add-custom-instructions/architect-mode-prompt.snap) and confirming it references./plansrelative to the workspace root.Pre-Submission Checklist
Screenshots / Videos
N/A — prompt-text change only; no UI surface is affected.
Documentation Updates
/plansbehavior; this restores the intended workspace-relative behavior.Additional Notes
Optional future hardening (out of scope here): normalizing or rejecting workspace-escaping absolute paths in
write_to_fileso an absolute/planspath resolves inside the workspace or is rejected with a clear error.Linked work items
Closes #965