chore(lint): add core/webview to no-floating-promises ratchet

src/core/webview/ClineProvider.ts

@@ -142,7 +142,7 @@ function runDelegationTransition<T>(
 
 	locks.set(parentTaskId, tail)
 
-	tail.finally(() => {
+	void tail.finally(() => {
 		if (locks.get(parentTaskId) === tail) {
 			locks.delete(parentTaskId)
 		}
@@ -234,7 +234,7 @@ export class ClineProvider
 		ClineProvider.activeInstances.add(this)
 
 		this.mdmService = mdmService
-		this.updateGlobalState("codebaseIndexModels", EMBEDDING_MODEL_PROFILES)
+		void this.updateGlobalState("codebaseIndexModels", EMBEDDING_MODEL_PROFILES)
 
 		// Initialize the per-task file-based history store.
 		// The globalState write-through is debounced separately (not on every mutation)
@@ -687,7 +687,7 @@ export class ClineProvider
 		this.mcpHub = undefined
 		await this.skillsManager?.dispose()
 		this.skillsManager = undefined
-		this.marketplaceManager?.cleanup()
+		await this.marketplaceManager?.cleanup()
 		this.customModesManager?.dispose()
 		this.taskHistoryStore.dispose()
 		this.flushGlobalStateWriteThrough()
@@ -822,9 +822,27 @@ export class ClineProvider
 			setPanel(webviewView, "sidebar")
 		}
 
+		// Set up webview options with proper resource roots
+		const resourceRoots = [this.contextProxy.extensionUri]
+
+		// Add workspace folders to allow access to workspace files
+		if (vscode.workspace.workspaceFolders) {
+			resourceRoots.push(...vscode.workspace.workspaceFolders.map((folder) => folder.uri))
+		}
+
+		webviewView.webview.options = {
+			enableScripts: true,
+			localResourceRoots: resourceRoots,
+		}
+
+		webviewView.webview.html =
+			this.contextProxy.extensionMode === vscode.ExtensionMode.Development
+				? await this.getHMRHtmlContent(webviewView.webview)
+				: await this.getHtmlContent(webviewView.webview)
+
 		// Initialize out-of-scope variables that need to receive persistent
 		// global state values.
-		this.getState().then(
+		await this.getState().then(
 			({
 				terminalShellIntegrationTimeout = Terminal.defaultShellIntegrationTimeout,
 				terminalShellIntegrationDisabled = false,
@@ -852,24 +870,6 @@ export class ClineProvider
 			},
 		)
 
-		// Set up webview options with proper resource roots
-		const resourceRoots = [this.contextProxy.extensionUri]
-
-		// Add workspace folders to allow access to workspace files
-		if (vscode.workspace.workspaceFolders) {
-			resourceRoots.push(...vscode.workspace.workspaceFolders.map((folder) => folder.uri))
-		}
-
-		webviewView.webview.options = {
-			enableScripts: true,
-			localResourceRoots: resourceRoots,
-		}
-
-		webviewView.webview.html =
-			this.contextProxy.extensionMode === vscode.ExtensionMode.Development
-				? await this.getHMRHtmlContent(webviewView.webview)
-				: await this.getHtmlContent(webviewView.webview)
-
 		// Sets up an event listener to listen for messages passed from the webview view context
 		// and executes code based on the message that is received.
 		this.setWebviewMessageListener(webviewView.webview)
@@ -892,7 +892,7 @@ export class ClineProvider
 			// for this visibility listener panel.
 			const viewStateDisposable = webviewView.onDidChangeViewState(() => {
 				if (this.view?.visible) {
-					this.postMessageToWebview({ type: "action", action: "didBecomeVisible" })
+					void this.postMessageToWebview({ type: "action", action: "didBecomeVisible" })
 				} else {
 					this.logWebviewHiddenDiagnostics()
 				}
@@ -903,7 +903,7 @@ export class ClineProvider
 			// sidebar
 			const visibilityDisposable = webviewView.onDidChangeVisibility(() => {
 				if (this.view?.visible) {
-					this.postMessageToWebview({ type: "action", action: "didBecomeVisible" })
+					void this.postMessageToWebview({ type: "action", action: "didBecomeVisible" })
 				} else {
 					this.logWebviewHiddenDiagnostics()
 				}
@@ -2107,7 +2107,7 @@ export class ClineProvider
 		const state = await this.getStateToPostToWebview()
 		this.clineMessagesSeq++
 		state.clineMessagesSeq = this.clineMessagesSeq
-		this.postMessageToWebview({ type: "state", state })
+		await this.postMessageToWebview({ type: "state", state })
 	}
 
 	/**
@@ -2123,7 +2123,7 @@ export class ClineProvider
 		this.clineMessagesSeq++
 		state.clineMessagesSeq = this.clineMessagesSeq
 		const { taskHistory: _omit, ...rest } = state
-		this.postMessageToWebview({ type: "state", state: rest })
+		await this.postMessageToWebview({ type: "state", state: rest })
 	}
 
 	/**
@@ -2140,7 +2140,7 @@ export class ClineProvider
 	async postStateToWebviewWithoutClineMessages(): Promise<void> {
 		const state = await this.getStateToPostToWebview()
 		const { clineMessages: _omitMessages, taskHistory: _omitHistory, ...rest } = state
-		this.postMessageToWebview({ type: "state", state: rest })
+		await this.postMessageToWebview({ type: "state", state: rest })
 	}
 
 	/**
@@ -2160,7 +2160,7 @@ export class ClineProvider
 			])
 
 			// Send marketplace data separately
-			this.postMessageToWebview({
+			await this.postMessageToWebview({
 				type: "marketplaceData",
 				organizationMcps: marketplaceResult.organizationMcps || [],
 				marketplaceItems: marketplaceResult.marketplaceItems || [],
@@ -2171,7 +2171,7 @@ export class ClineProvider
 			console.error("Failed to fetch marketplace data:", error)
 
 			// Send empty data on error to prevent UI from hanging
-			this.postMessageToWebview({
+			await this.postMessageToWebview({
 				type: "marketplaceData",
 				organizationMcps: [],
 				marketplaceItems: [],
@@ -2954,7 +2954,7 @@ export class ClineProvider
 				if (currentManager === this.getCurrentWorkspaceCodeIndexManager()) {
 					// Get the full status from the manager to ensure we have all fields correctly formatted
 					const fullStatus = currentManager.getCurrentStatus()
-					this.postMessageToWebview({
+					void this.postMessageToWebview({
 						type: "indexingStatusUpdate",
 						values: fullStatus,
 					})
@@ -2966,7 +2966,7 @@ export class ClineProvider
 			}
 
 			// Send initial status for the current workspace
-			this.postMessageToWebview({
+			void this.postMessageToWebview({
 				type: "indexingStatusUpdate",
 				values: currentManager.getCurrentStatus(),
 			})

src/core/webview/__tests__/ClineProvider.spec.ts

@@ -1149,7 +1149,7 @@ describe("ClineProvider", () => {
 			setModeConfig: vi.fn(),
 		} as any
 
-		provider.setValue("currentApiConfigName", "current-config")
+		await provider.setValue("currentApiConfigName", "current-config")
 
 		// Switch to architect mode
 		await messageHandler({ type: "mode", text: "architect" })
@@ -1247,7 +1247,7 @@ describe("ClineProvider", () => {
 			},
 		}
 
-		provider.setValue("customModePrompts", existingPrompts)
+		await provider.setValue("customModePrompts", existingPrompts)
 
 		// Test updating a prompt
 		await messageHandler({

src/core/webview/checkpointRestoreHandler.ts

@@ -31,7 +31,7 @@ export async function handleCheckpointRestoreOperation(config: CheckpointRestore
 		// This prevents "Current ask promise was ignored" errors
 		// For edit operations, we don't abort because the checkpoint restore will handle it
 		if (operation === "delete" && currentCline && !currentCline.abort) {
-			currentCline.abortTask()
+			await currentCline.abortTask()
 			// Wait a bit for the abort to complete
 			await pWaitFor(() => currentCline.abort === true, {
 				timeout: 1000,

src/core/webview/rulesMessageHandler.ts

@@ -38,7 +38,7 @@ export async function handleCreateRule(
 	try {
 		const input = parseCreateRuleInput(message)
 		const createdPath = await createRule(cwd, input)
-		openFile(createdPath)
+		await openFile(createdPath)
 	} catch (error) {
 		const errorMessage = getErrorMessage(error)
 		provider.log(`Error creating rule: ${errorMessage}`)
@@ -89,7 +89,7 @@ export async function handleOpenRuleFile(provider: ClineProvider, cwd: string, m
 			throw new Error("Rule file not found")
 		}
 
-		openFile(filePath)
+		await openFile(filePath)
 	} catch (error) {
 		const errorMessage = getErrorMessage(error)
 		provider.log(`Error opening rule file: ${errorMessage}`)
@@ -109,7 +109,7 @@ export async function handleOpenRulesDirectory(
 			kind: values.kind,
 			modeSlug: values.modeSlug,
 		} as CreateRuleInput)
-		openFile(directoryPath)
+		await openFile(directoryPath)
 	} catch (error) {
 		const errorMessage = getErrorMessage(error)
 		provider.log(`Error opening rules directory: ${errorMessage}`)

src/core/webview/skillsMessageHandler.ts

@@ -55,7 +55,7 @@ export async function handleCreateSkill(
 		const createdPath = await skillsManager.createSkill(skillName, source, skillDescription, modeSlugs)
 
 		// Open the created file in the editor
-		openFile(createdPath)
+		await openFile(createdPath)
 
 		// Send updated skills list
 		const skills = skillsManager.getSkillsMetadata()
@@ -199,7 +199,7 @@ export async function handleOpenSkillFile(provider: ClineProvider, message: Webv
 			throw new Error(t("skills:errors.skill_not_found", { name: skillName }))
 		}
 
-		openFile(skill.path)
+		await openFile(skill.path)
 	} catch (error) {
 		const errorMessage = error instanceof Error ? error.message : String(error)
 		provider.log(`Error opening skill file: ${errorMessage}`)