Skip to content

🛡️ Sentinel: [security improvement] Suppress SAST false positives #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manupawickramasinghe merged 1 commit into from
Jun 16, 2026
Merged

🛡️ Sentinel: [security improvement] Suppress SAST false positives #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions testping1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import os
import subprocess
import subprocess # nosec B404
import concurrent.futures
import ipaddress
import logging
Expand Down Expand Up @@ -235,7 +235,7 @@ def is_reachable(ip, timeout=1):
try:
# 🛡️ Sentinel: Add python-level timeout limit as defense-in-depth to prevent
# worker thread pool exhaustion if the underlying ping process hangs.
return subprocess.call(command, stdout=DEVNULL_FD, stderr=DEVNULL_FD, close_fds=True, timeout=timeout_val + 2) == 0
return subprocess.call(command, stdout=DEVNULL_FD, stderr=DEVNULL_FD, close_fds=True, timeout=timeout_val + 2) == 0 # nosec B603
except OSError:
# 🛡️ Sentinel: Fail securely on command execution errors (like FileNotFoundError)
# to prevent unhandled exceptions crashing the worker thread pool and leaking stack traces.
Expand Down
Loading