feat: confirm consequential payment and journal creates - #40
Draft
ryanduguid wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migration and limits
This intentionally changes both create commands. Run the unchanged command with --dry-run, review its organisation tenant ID and redacted summary, then rerun it with --confirm and the printed value.
The confirmation is deterministic, reusable and non-expiring. It is not a secret, one-time token or cross-process replay guarantee. A tenant, operation or payload change invalidates it.
Relationship
Depends on #39. This branch includes #39 as its first commit so the confirmation gate is validated together with strict calendar parsing and DRAFT, finite, exact-cent balanced manual-journal validation. Review commit 20b06d5 for this PR's confirmation-specific change.
Validation
The command tests inject fake Xero clients. No Xero API or external financial service was called. The passing command-test run emits an @oclif/core optional dev-plugin discovery warning for @oclif/plugin-plugins; exit status remains zero.