Validate and escape OAuth callbacks - #33
Draft
ryanduguid wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the local PKCE callback without changing the successful login flow.
error_descriptionin browser or terminal output;Security impact
This makes the callback state check authoritative and removes the reflected-XSS/privacy path from provider-controlled callback text. Default upstream remains vulnerable until this branch is merged.
Verification at
44e84244c42358099783241250d0417ea6db3af0npx vitest run test/lib/oauth.test.ts— 6 passed;npm run buildpassed;git diff --checkpassed.No browser, Xero API or external service was contacted.