ci: correlate codegen validation runs - #836
Draft
ryanduguid wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Concurrent pull requests can currently select each other's codegen runs, which can report the wrong validation result. GitHub's dispatch API now returns the created run ID when
return_run_detailsis enabled.Validation
actionlint .github/workflows/pr-validation.ymlgit diff --checkThe private codegen repository and its application credentials are intentionally not accessible to this contribution. Maintainers should confirm one real dispatch in the trusted upstream environment before taking this pull request out of draft.