fix(files): remove invalid FileObject requirements - #833
Draft
ryanduguid wants to merge 1 commit into
Draft
Conversation
ryanduguid
marked this pull request as draft
August 12, 2026 17:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
FileObjectschemaPUT /Files/{FileId}request body (for example,{ "FolderId": "..." })FileObjectis shared by file responses and the partial-update request body. Replacing the fields withName/Idwould still make valid partial updates invalid. Removing the list is mechanically consistent with the partial-update example, but may weaken the response contract; splitting request and response schemas may be the correct domain-owned solution.Limited verification
FolderId-only PUT example against the proposedFileObjectwithjsonschemanpx -y @redocly/cli lint xero_files.yaml --format stylish: removes the fourFileObjectno-required-schema-properties-undefinedwarnings; the file retains unrelated baseline lint findingsThese checks establish schema mechanics only. They are not authoritative evidence for Files API field requiredness.