[XAPI-2340] Open a PR for OAuth2Client version bumps instead of pushing to master - #664
Merged
Merged
Conversation
the-chris-mitchell
marked this pull request as ready for review
August 10, 2026 04:24
nca-work
approved these changes
Aug 10, 2026
added 2 commits
August 10, 2026 16:48
…ng to master master is a protected branch requiring PRs and a passing status check, so the workflow's direct `git push origin HEAD:master` always failed once there were actual changes to publish (every prior "successful" run had short-circuited before reaching this step). The version bump commit and tag are now pushed to a branch and opened as a PR instead, with the PR URL surfaced in the job's step summary.
the-chris-mitchell
force-pushed
the
xapi-2340-fix-client-publish-pr-flow
branch
from
August 10, 2026 04:48
f9bb1c2 to
abc88a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit, Push and Tagstep inpublish-Oauth2Client-package.ymlpushes directly tomaster, butmasteris a protected branch requiring a PR + thebuild-test-lintstatus check. Every prior "successful" run of this workflow had actually short-circuited before this step (no changes detected), so this direct push has likely never worked when there were real changes to publish. See run 31353584005 for the failure.GITHUB_TOKENcan't be granted bypass on the ruleset — bypass actors are limited to specific roles, teams, installed GitHub Apps, or Dependabot, not the generic Actions token identity.master→ surface the PR URL in the job's$GITHUB_STEP_SUMMARY.Prerequisite to verify
gh pr createin the new step will fail.Test plan
Publish OAuth2Client Packagewith a real OAuth2Client change and confirm the new step opens a PR and the step summary links to itJira: https://xero.atlassian.net/browse/XAPI-2340
🤖 Generated with Claude Code