Skip to content

fix: avoid shell interpolation of SLURM_NODELIST (CVE-2024-27763) #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christopher5106 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: avoid shell interpolation of SLURM_NODELIST (CVE-2024-27763) #765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion basicsr/utils/dist_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,14 @@ def _init_dist_slurm(backend, port=None):
node_list = os.environ['SLURM_NODELIST']
num_gpus = torch.cuda.device_count()
torch.cuda.set_device(proc_id % num_gpus)
addr = subprocess.getoutput(f'scontrol show hostname {node_list} | head -n1')
# `SLURM_NODELIST` is environment-controlled input, so it is passed as an argv
# element instead of being interpolated into a shell command (CVE-2024-27763).
# `head -n1` is replaced by taking the first line in Python.
hostnames = subprocess.run(['scontrol', 'show', 'hostname', node_list],
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
text=True).stdout
addr = hostnames.split('\n')[0]
# specify master port
if port is not None:
os.environ['MASTER_PORT'] = str(port)
Expand Down