Version correction - #182
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe changes finalize the XOOPS version string, remove the 2.7.3 release announcement content, and delete tests for query-string rebuilding. ChangesRelease finalization
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change finalizes the release version metadata and removes obsolete release and test artifacts; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Title checkExplanation The title identifies the main change: correcting the reported XOOPS version from the release candidate to the final release. It does not mention the removed release document or unit test, but the title does not need to cover every change. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 PHPStan (2.2.8)PHP Fatal error: Uncaught Error: Class "Nette\DI\ServiceCreationException" not found in /.cache/phpstan/phpstan/cache/nette.configurator/Container_ea160b8438.php:8682 ... [truncated 2699 characters] ... an\Command\AnalyseCommand->execute() Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR finalizes the reported XOOPS version as 2.7.3 and removes the release-post draft plus the RebuildQueryString unit test file. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #182 +/- ##
============================================
+ Coverage 20.18% 20.23% +0.04%
- Complexity 8217 8233 +16
============================================
Files 673 674 +1
Lines 44242 44297 +55
============================================
+ Hits 8930 8962 +32
- Misses 35312 35335 +23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Greptile SummaryThe PR corrects the runtime version label from the 2.7.3 release candidate to 2.7.3 Final, but its merge also removes two release-related artifacts.
Confidence Score: 4/5The runtime version correction appears safe to merge, but restoring the deleted regression test and BBCode release artifact would avoid two non-blocking regressions. The corrected version string does not affect inspected upgrade behavior, while the remaining concerns are loss of targeted automated coverage and a publication-ready documentation format rather than current runtime defects. Files Needing Attention: tests/unit/htdocs/include/RebuildQueryStringTest.php, docs/RELEASE_POST_BBCODE.txt
|
| Filename | Overview |
|---|---|
| htdocs/include/version.php | Corrects the displayed release identifier to 2.7.3 Final; inspected consumers do not introduce upgrade or compatibility failures. |
| tests/unit/htdocs/include/RebuildQueryStringTest.php | Deletes the only direct regression coverage for a live, security-sensitive redirect query-string helper. |
| docs/RELEASE_POST_BBCODE.txt | Deletes the publication-ready BBCode release announcement while equivalent content remains only in Markdown. |
Comments Outside Diff (2)
-
tests/unit/htdocs/include/RebuildQueryStringTest.phpRedirect regression coverage removed
Deleting this file removes the only direct tests for the active
xoops_rebuildQueryString()helper, so regressions in safe encoding or preservation of legitimate long redirect targets will no longer be caught by the PHPUnit suite.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
-
docs/RELEASE_POST_BBCODE.txtDeleting this publication-ready BBCode announcement leaves only the Markdown version, requiring maintainers to reconstruct and recheck the xoops.org news-post formatting during the release process.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Reviews (1): Last reviewed commit: "Merge branch 'master' of https://github...." | Re-trigger Greptile
There was a problem hiding this comment.
Pull request overview
This PR finalizes XOOPS 2.7.3 release metadata by updating the reported core version and removing obsolete release/test artifacts.
Changes:
- Update
XOOPS_VERSIONfromXOOPS 2.7.3-RC1toXOOPS 2.7.3. - Remove the BBCode-formatted release post document.
- Remove the
RebuildQueryStringunit test file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
htdocs/include/version.php |
Updates the core-reported XOOPS version string to the final 2.7.3 value. |
docs/RELEASE_POST_BBCODE.txt |
Removes an obsolete BBCode release-post artifact. |
tests/unit/htdocs/include/RebuildQueryStringTest.php |
Removes unit tests for the redirect query-string rebuilding helper. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| * Define XOOPS version | ||
| */ | ||
| define('XOOPS_VERSION', 'XOOPS 2.7.3-RC1'); | ||
| define('XOOPS_VERSION', 'XOOPS 2.7.3'); |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary by Sourcery
Finalize the project release metadata and remove obsolete release and test artifacts.
Documentation:
Tests:
Chores:
Summary by CodeRabbit
Release
Documentation
Maintenance