Decompose large indexing and query orchestration - #5078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Several core paths had grown into very large classes and methods with duplicated mutable state, callback-heavy context objects, and difficult lifetime boundaries. This series makes those boundaries explicit while preserving transaction, cancellation, schema-fallback, and output behavior.
The branch contains 45 focused commits so each extraction or correction remains independently reviewable.
Correctness fixes
No open issue is auto-closed by this PR.
Validation
dotnet format CodeIndex.sln whitespace --no-restore --verify-no-changesdotnet run --project tools/CodeIndex.Changelog -- check— 4 fragments validated.git diff --check origin/main..HEADDocumentation and changelog
Behavioral contracts were documented in the English and Japanese sections of
TESTING_GUIDE.md.Changelog fragments:
changelog.d/unreleased/+batch-output-limit-replay.fixed.mdchangelog.d/unreleased/+csharp-base-list-parser.fixed.mdchangelog.d/unreleased/+full-scan-extraction-state.fixed.mdchangelog.d/unreleased/+unused-legacy-schema.fixed.mdFollow-up candidates
No correctness follow-up is required. Further decomposition of transaction-heavy full-scan/readiness tails and baseline per-file persistence carriers is intentionally deferred to separately characterized changes.