Skip to content

fix(setSinkId): use requested sink for resource acquisition #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whizzkid1452 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(setSinkId): use requested sink for resource acquisition #2684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ea8e44
fix(setSinkId): use requested sink for resource acquisition
Jul 3, 2026
5c8ae1d
fix(pr-preview): allow existing Bikeshed messages
Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .pr-preview.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"src_file": "index.bs",
"type": "bikeshed",
"params": {
"force": 1
"force": 1,
"die-on": "nothing"
}
}
6 changes: 4 additions & 2 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2275,11 +2275,13 @@ Methods</h4>
associated {{AudioContext}}.

1. Attempt to <a href="#acquiring">acquire system resources</a> to use
a following audio output device based on {{AudioContext/[[sink ID]]}}
the following output target based on |sinkId|
for rendering:

* The default audio output device for the empty string.
* A audio output device identified by {{AudioContext/[[sink ID]]}}.
* An audio output device identified by |sinkId|.
* No audio output device for an {{AudioSinkOptions}} whose
{{AudioSinkOptions/type}} is "{{AudioSinkType/none}}".

In case of failure, reject |p| with "{{InvalidAccessError}}" abort
the following steps.
Expand Down