Spectec for binary format of types and instructions - #108
Open
tlively wants to merge 1 commit into
Open
Conversation
tlively
commented
Jul 16, 2026
| | 0x4D x:Btypeidx => DESCRIPTOR (_IDX x) | ||
|
|
||
| grammar Bdesctype : desctype = | ||
| | describestype:Bdescribestype descriptortype:Bdescriptortype ct:Bcomptype => describestype descriptortype ct |
Member
Author
There was a problem hiding this comment.
We probably want some other variable names here. I can use dt1 and dt2, but not dt_1 and dt_2 because dt is already taken by deftype. Any suggestions?
Member
There was a problem hiding this comment.
How about just d_1, d_2? I think d isn't taken globally.
Btw, how about dropping the type suffix on describes/descriptortype? These names are a mouthful, and they aren't really types in their own right anyway, more like modifiers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.