Skip to content

[DebugInfo] Do not assert on an unmarked end of a span - #8943

Open
kripken wants to merge 1 commit into
WebAssembly:mainfrom
kripken:no.end
Open

[DebugInfo] Do not assert on an unmarked end of a span#8943
kripken wants to merge 1 commit into
WebAssembly:mainfrom
kripken:no.end

Conversation

@kripken

@kripken kripken commented Jul 28, 2026

Copy link
Copy Markdown
Member

#8862 added binary tracking of Try, but it does not always fully work:
sometimes we note the start of a Try (this happens when we see a
Catch/CatchAll, and end the scope of the Try body), but we never
mark the end, because push() is not called on the Try in
wasm-ir-builder.cpp.

I could not quite figure out why push() is not called, and neither
could AI. It might be good to investigate this further, I left a
TODO, however, if we are dropping a little bit of debug info on
Try instructions then that is likely not a big deal, and also we were
doing it before #8862 anyhow.

Works around #8940

@kripken
kripken requested a review from tlively July 28, 2026 15:53
@kripken
kripken requested a review from a team as a code owner July 28, 2026 15:53
@tlively

tlively commented Jul 28, 2026

Copy link
Copy Markdown
Member

Can you share a reproducer? I'd be happy to look into what is going wrong in IRBuilder.

@kripken

kripken commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

Sure, there is a reproducer in the linked issue that this works around, #8940

@kripken

kripken commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

Btw, maybe our code is too complex if neither I nor AI could figure this out in a few hours? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants