[DebugInfo] Do not assert on an unmarked end of a span - #8943
Open
kripken wants to merge 1 commit into
Open
Conversation
Member
|
Can you share a reproducer? I'd be happy to look into what is going wrong in IRBuilder. |
Member
Author
|
Sure, there is a reproducer in the linked issue that this works around, #8940 |
Member
Author
|
Btw, maybe our code is too complex if neither I nor AI could figure this out in a few hours? 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8862 added binary tracking of Try, but it does not always fully work:
sometimes we note the start of a Try (this happens when we see a
Catch/CatchAll, and end the scope of the Try body), but we never
mark the end, because
push()is not called on the Try inwasm-ir-builder.cpp.I could not quite figure out why
push()is not called, and neithercould AI. It might be good to investigate this further, I left a
TODO, however, if we are dropping a little bit of debug info on
Try instructions then that is likely not a big deal, and also we were
doing it before #8862 anyhow.
Works around #8940