Conversation
Add --per-snapshot CLI option that shows a column-aligned per-snapshot table (Unique Size / Shared Size / Total Size) below each guest summary when used with --all-guests or a single --searchpath. When combined with --csv-dir, an additional CSV file (snapshots_*.csv) is written with per-snapshot columns: namespace_path, snapshot_name, unique_bytes, shared_bytes, total_bytes, unique_chunks. The overall guest-level summary remains identical to the existing implementation -- per-snapshot breakdown is computed as extra data from the same index file analysis.
- Bump __version__ to 2.12.0 (new feature → minor bump) - Add CHANGELOG entry for 2.12.0 - Add usage examples for --per-snapshot (single guest and --all-guests) - Add --per-snapshot row to the parameter table - Add new section explaining the per-snapshot columns (Unique / Shared / Total) and the snapshots_*.csv output format
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a490c2fa6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if args.per_snapshot and not args.all_guests and not args.searchpath: | ||
| parser.error( | ||
| "--per-snapshot requires either --all-guests or a single guest searchpath." | ||
| ) |
There was a problem hiding this comment.
This validation only checks that --searchpath is present, so --per-snapshot also accepts namespace/root paths (for example /ns/team). In that case main() still calls analyze_guest_per_snapshot(...), which groups indexes by parent directory name and can merge same-named snapshot folders from different guests, producing incorrect unique/shared per-snapshot totals without any error. Please validate non---all-guests paths as a single guest directory (.../(vm|ct)/<id>) before allowing this mode.
Useful? React with 👍 / 👎.
2 participants
No description provided.