feat(vtable): add audio cell type support - #5275
Open
fangsmile wants to merge 7 commits into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Tighten audio URL detection and preserve media icon layout. Align audio docs with supported options. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Export the audio column type. Keep audio out of image sizing paths. Clear stale video graphics on reused cells. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Track video cell media nodes with an internal marker. Keep user icons named image or play-icon during reuse. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
audiocell type rendering, media URL detection, and click-to-preview support.Test plan
node ../../common/scripts/install-run-rushx.js compileinpackages/vtablenode ../../common/scripts/install-run-rushx.js test -- cell-type/video-cell-first-frame.test.ts --runInBandinpackages/vtablegit pushpre-push hook still fails in@visactor/vtable-sheetunrelated formula tests:__tests__/nested-formula-engine.test.ts🤖 Generated with Claude Code