Build macOS universal binary (arm64 + x86_64)#138
Open
karlhiramoto wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the build process to generate a macOS universal binary containing both
x86_64andarm64architectures.Previously, the macOS binary was
x86_64only (vt: Mach-O 64-bit executable x86_64), which required Rosetta 2 to run on Apple Silicon Macs. This change fixes the binary for Apple Silicon machines that do not have Rosetta 2 installed.Changes:
darwin/amd64anddarwin/arm64, then combine them usinglipo.makefat(viago run) whenlipois not available, ensuring that the build still succeeds on Linux-based CI runners (like GitHub Actionsubuntu-latest).MacOSX.zip.