feat(test): add data-testid hooks to map components for stable e2e#376
Open
mercy60 wants to merge 1 commit into
Open
feat(test): add data-testid hooks to map components for stable e2e#376mercy60 wants to merge 1 commit into
mercy60 wants to merge 1 commit into
Conversation
Closes VertexChainLabs#153 - MapLoader: add map-loader - Map: add map-add-gist-button - AddGistModal: add map-add-gist-modal, map-add-gist-modal-input, map-add-gist-modal-submit - Migrate Frontend/e2e/map.spec.ts to getByTestId selectors so the suite survives i18n / copy changes / visual refactors - Add Frontend/CONTRIBUTING.md documenting the kebab-case data-testid convention (issue VertexChainLabs#153) - All aria-labels, aria-labelledby, role, and visible text retained for assistive tech and unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #153
MapLoader: add map-loader
Map: add map-add-gist-button
AddGistModal: add map-add-gist-modal, map-add-gist-modal-input, map-add-gist-modal-submit
Migrate Frontend/e2e/map.spec.ts to getByTestId selectors so the suite survives i18n / copy changes / visual refactors
Add Frontend/CONTRIBUTING.md documenting the kebab-case data-testid convention (issue Add
data-testidhooks to map components for stable e2e #153)All aria-labels, aria-labelledby, role, and visible text retained for assistive tech and unit tests.
Pull Request
Please provide a short description of the change and link any related issues.
PR Title Format Guidelines (Required)
Please ensure your PR title follows the Conventional Commits header format:
type(scope): subjectortype: subjectdocs,feat,fix,chore,ci, etc.).docs: add initial ADRs,feat(api): add user authDescription
Checklist
Security
If this change includes anything security-sensitive (secrets, auth changes, data exposure), describe mitigations and whether coordinated disclosure is required.
Notes for reviewers