contracts(multisig): validate amount > 0 and to != from in submit_transaction#338
Open
benzy018 wants to merge 1 commit into
Open
Conversation
…nsaction - Add SelfTransfer = 14 variant to MultiSigError enum - Reject amount <= 0 with InvalidAmount error in submit_transaction - Reject caller == to with SelfTransfer error in submit_transaction - Add test_submit_transaction_rejects_zero_amount - Add test_submit_transaction_rejects_negative_amount - Add test_submit_transaction_rejects_self_transfer Closes VertexChainLabs#130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the two validation gaps identified in issue #130.
Changes in
contracts/multisig/src/lib.rs:SelfTransfer = 14variant toMultiSigErrorenumsubmit_transactionnow rejectsamount <= 0withInvalidAmount (#6)before storing any statesubmit_transactionnow rejectscaller == towithSelfTransfer (#14)before storing any stateWhy
amount = 0or negative amounts silently inflates on-chain pending-tx storage budget with useless entries.Tests Added
test_submit_transaction_rejects_zero_amountError(Contract, #6)test_submit_transaction_rejects_negative_amountError(Contract, #6)test_submit_transaction_rejects_self_transferError(Contract, #14)All three tests follow the exact same pattern as the existing
test_cannot_initialize_twicetest using Soroban's#[should_panic(expected = "Error(Contract, #N)")]convention.Acceptance Criteria
to == caller) are rejectedCloses #130