chore: add hadolint CI job for Dockerfiles#216
Open
DevALVIN-24 wants to merge 1 commit into
Open
Conversation
Contributor
|
Contracts CI is currently failing \xe2\x9d\x97\xe2\x83\xa3 \xe2\x80\x94 could you take a look at the Soroban workflow logs and push a fix? Once green we're ready to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr closes #160
Description
This PR resolves the issue where the
docker/*.Dockerfilefiles were not linted. A linted Dockerfile builds faster, is smaller, and limits security vulnerabilities.Changes Included
.github/workflows/container-lint.ymlto run thehadolintCI check automatically on bothdocker/backend.Dockerfileanddocker/frontend.Dockerfilewhenever changes are pushed or a pull request is raised..hadolint.yamlto ensure the lint step effectively enforces rules. Currently, it triggers failure only on a warnings threshold and correctly suppresses known benignapk addversion-pinning rules (DL3018) that would unnecessarily block builds.How to Verify
When you open this PR, you should see the new
Container Lintjob executing in GitHub Actions. It should succeed (if no other issues are present) and automatically check for common traps such asapt-getissues or missing configurations.