feat: error boundaries for landing and map pages#206
Open
benzy018 wants to merge 1 commit into
Open
Conversation
Add Next.js App Router error.tsx files for the root and /map routes so render-time exceptions show a styled fallback with a retry button instead of crashing the page. - Frontend/src/app/error.tsx – global fallback (GlobalError) - Frontend/src/app/map/error.tsx – map-specific fallback (MapError) - Colocated Vitest tests (11 tests, all passing) Closes VertexChainLabs#143
Contributor
|
The Soroban contracts CI job is failing \xe2\x9d\x97\xe2\x83\xa3 \xe2\x80\x94 could you check the workflow logs and push a fix? Once green, ready to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Next.js App Router
error.tsxfiles for the root and/maproutes so any render-time exception shows a styled fallback with a "Try again" retry button instead of crashing the page.Changes
Frontend/src/app/error.tsxGlobalError) – catches errors in any routeFrontend/src/app/map/error.tsxMapError) – scoped fallback for the map pageFrontend/src/app/error.test.tsxFrontend/src/app/map/error.test.tsxAcceptance criteria
reset()bg-[#111827]) and indigo accent (#6366f1) match project conventionsvitest run)Testing
Closes #143