fix(agent): skip on-call escalation when the workflow is not initialized - #261
Open
nghiadaulau wants to merge 1 commit into
Open
fix(agent): skip on-call escalation when the workflow is not initialized#261nghiadaulau wants to merge 1 commit into
nghiadaulau wants to merge 1 commit into
Conversation
CreateIncidentFromFinding sets the oncall_enable=true query-param override for high/critical AI findings. When on-call was disabled at startup (oncall.enable and oncall.initialized_only both false) InitOnCallWorkflow is never called, so GetOnCallWorkflow() panicked and took down the agent tick goroutine on the first detect-mode emit of a high/critical pattern. Add core.IsOnCallInitialized() and guard the escalation: when on-call is requested but uninitialized, log a warning and skip instead of crashing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CreateIncidentFromFindingsets theoncall_enable=truequery-param override for high/critical AI findings. When on-call is disabled at startup (oncall.enableandoncall.initialized_onlyboth false),InitOnCallWorkflowis never called, socore.GetOnCallWorkflow()panics — taking down the agent tick goroutine on the first detect-mode emit of a high/critical pattern.Fix
core.IsOnCallInitialized().CreateIncident: when on-call is requested but the workflow was never initialized, log a warning and skip escalation instead of crashing. Channel fan-out (which runs first) is unaffected, so the alert still reaches Telegram/Slack/etc.Verified
Reproduced on minikube (agent detect mode + Gemini, on-call disabled): before the fix the pod crash-looped on the first emit; after, the agent emits the incident to Telegram and logs
... on-call escalation requested but the workflow is not initialized ... skipping escalation.go test ./pkg/services/... ./pkg/core/...passes.🤖 Generated with Claude Code