-
Notifications
You must be signed in to change notification settings - Fork 16
chore(deps): upgrade ESLint from v8 to v9 with flat config migration #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| const js = require('@eslint/js') | ||
| const typescriptEslint = require('@typescript-eslint/eslint-plugin') | ||
| const tsParser = require('@typescript-eslint/parser') | ||
| const globals = require('globals') | ||
| const simpleImportSort = require('eslint-plugin-simple-import-sort') | ||
| const prettierRecommended = require('eslint-plugin-prettier/recommended') | ||
|
|
||
| module.exports = [ | ||
| { | ||
| ignores: [ | ||
| '**/node_modules/**', | ||
| 'lib/**', | ||
| 'sample/**', | ||
| // Codegen spec files have strict type requirements (Object vs object, semicolons) | ||
| // dictated by React Native's codegen — do not lint or auto-fix these. | ||
| 'src/fabric/**', | ||
| ], | ||
| }, | ||
| js.configs.recommended, | ||
| prettierRecommended, | ||
| // Prettier formatting is advisory — existing files with different style won't block CI. | ||
| { rules: { 'prettier/prettier': 'warn' } }, | ||
| // CommonJS config/script files | ||
| { | ||
| files: ['**/*.js', '**/*.jsx'], | ||
| languageOptions: { | ||
| globals: { | ||
| ...globals.commonjs, | ||
| ...globals.node, | ||
| }, | ||
| }, | ||
| }, | ||
| // TypeScript source files | ||
| { | ||
| files: ['**/*.ts', '**/*.tsx'], | ||
| languageOptions: { | ||
| parser: tsParser, | ||
| parserOptions: { | ||
| ecmaVersion: 'latest', | ||
| sourceType: 'module', | ||
| }, | ||
| }, | ||
| plugins: { | ||
| '@typescript-eslint': typescriptEslint, | ||
| 'simple-import-sort': simpleImportSort, | ||
| }, | ||
| rules: { | ||
| ...typescriptEslint.configs.recommended.rules, | ||
| // Wrapper types (String/Number/Boolean/Object) exist in pre-existing model files; | ||
| // downgrade so existing code doesn't block CI. | ||
| '@typescript-eslint/no-wrapper-object-types': 'warn', | ||
| 'import/order': 'off', | ||
|
uc-brunosilva marked this conversation as resolved.
|
||
| // Warn rather than error so pre-existing unsorted imports don't block CI. | ||
| 'simple-import-sort/exports': 'warn', | ||
| 'simple-import-sort/imports': 'warn', | ||
| 'sort-imports': 'off', | ||
| }, | ||
| }, | ||
| // Test files — add jest globals and relax any-type rules used in mocks | ||
| { | ||
| files: [ | ||
| '**/__tests__/**/*.ts', | ||
| '**/__tests__/**/*.tsx', | ||
| '**/*.test.ts', | ||
| '**/*.test.tsx', | ||
| ], | ||
| languageOptions: { | ||
| globals: { | ||
| ...globals.jest, | ||
| }, | ||
| }, | ||
| rules: { | ||
| '@typescript-eslint/no-explicit-any': 'off', | ||
| }, | ||
| }, | ||
| ] | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.