Group connections into provider accounts with login_hint#1311
Open
RhysSullivan wants to merge 7 commits into
Open
Group connections into provider accounts with login_hint#1311RhysSullivan wants to merge 7 commits into
RhysSullivan wants to merge 7 commits into
Conversation
The list surface was carrying the full HealthCheckResult, including responseSample and detail, for every connection. Project it down to a lean ConnectionListHealth shape; the connections detail API keeps the full record.
Enable-services derived name and identityLabel from owner + integration only, so two same-owner accounts adding the same service collided on (owner, integration, name) and the second clobbered the first. Seed the label with the account email localpart so each account gets its own connection.
Extract the Continue handler as continueEnableServiceStep so the popup-open contract is testable: completing a step (success or failure) only records the result, and the next popup opens only on a fresh Continue click. Also cover the mount boundary: the modal renders nothing while closed or without an account, so the body and its OAuth flow unmount on close.
Contributor
Cloudflare preview
Sign-in is Cloudflare Access (one-time PIN to an allowed email). The preview has its own database and encryption key; it is destroyed when this PR closes. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 962df01 | Commit Preview URL Branch Preview URL |
Jul 04 2026, 07:50 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 962df01 | Jul 04 2026, 07:50 AM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a derived provider-account grouping (no new storage): connections on Google/Microsoft integrations group by probed account email, rendered as one account with its per-service connections. From an account row, additional services can be enabled one consent at a time; each consent carries login_hint so Google/Microsoft pre-select the account. Connection lists now expose a narrow lastHealth projection (status/identity/checkedAt) for the accounts view.
Independently reviewed (ship-with-nits; all three nits addressed: narrowed list projection, per-account connection naming, no-auto-chaining handler tests).