MinGW DLL improvements#44
Open
slipher wants to merge 3 commits into
Open
Conversation
The exact same code is there 80 lines up.
Use the --print-file-name option with MinGW GCC to get the locations of its DLLs, instead of searching for them in the filesystem. Well, this only actually works directly with Debian's packaging. On other distros, --print-file-name doesn't work on DLLs. For those we use it to locate a random static library, then hope that the DLL is in a `bin` directory which is a sibling of a `lib` directory containing the static lib. The method of getting the path to the compiler (via grepping in the CMake cache) is ugly, but overall it seems better than scanning the filesystem (which may have multiple toolchains installed) for DLLs and hoping we got the right one.
Starting with GCC 15 or 16, the compiler no longer emits libssp dependencies. Fixes build-release on MSYS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/usr.libssp-0.dllif it is not depended upon. The latest toolchains no longer emit this dependency.Tested on Debian, Arch, Fedora, and MSYS. Well, the build doesn't complete on Arch because its toolchains have an incompatible CRT flavor, but at least it gets past the DLL finding part.