fix(apollo-react): default add-node search placeholder to "Search nodes" [MST-11831]#880
Open
KodudulaAshishUiPath wants to merge 1 commit into
Open
fix(apollo-react): default add-node search placeholder to "Search nodes" [MST-11831]#880KodudulaAshishUiPath wants to merge 1 commit into
KodudulaAshishUiPath wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
Pull request overview
Updates the canvas add-node search UX copy in @uipath/apollo-react so the placeholder describes what the user is searching, aligning with the referenced content audit guidance.
Changes:
- Added a new Lingui message id for the add-node search placeholder and defaulted it to “Search nodes” in
AddNodePanel. - Extended
Toolboxwith an optionalsearchPlaceholderprop (default remains the existing generic “Search”). - Plumbed the optional
searchPlaceholderthroughAddNodePanelso hosts can override it with context-specific copy.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/apollo-react/src/canvas/locales/en.json | Adds addNodePanel.searchNodes English catalog entry (“Search nodes”). |
| packages/apollo-react/src/canvas/components/Toolbox/Toolbox.tsx | Introduces optional searchPlaceholder prop and applies it to the search input placeholder with a backwards-compatible default. |
| packages/apollo-react/src/canvas/components/AddNodePanel/AddNodePanel.types.ts | Adds optional searchPlaceholder prop to AddNodePanelProps. |
| packages/apollo-react/src/canvas/components/AddNodePanel/AddNodePanel.tsx | Defaults add-node placeholder to the new Lingui message (“Search nodes”) and passes through host override. |
Contributor
📊 Coverage + size by packagePer-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.
"Coverage" is each package's own |
SreedharAvvari
approved these changes
Jul 9, 2026
KodudulaAshishUiPath
force-pushed
the
fix/MST-11831-add-node-search-placeholder
branch
from
440cc27 to
7317713
Compare
KodudulaAshishUiPath
force-pushed
the
fix/MST-11831-add-node-search-placeholder
branch
from
7317713 to
2337a94
Compare
Comment on lines
160
to
+166
| fullHeight = false, | ||
| quickActions, | ||
| renderEmptyState, | ||
| searchPlaceholder: searchPlaceholderProp, | ||
| }: ToolboxProps<T>) { | ||
| const { _ } = useSafeLingui(); | ||
| const searchPlaceholder = _({ id: 'toolbox.search', message: 'Search' }); | ||
| const searchPlaceholder = searchPlaceholderProp ?? _({ id: 'toolbox.search', message: 'Search' }); |
Comment on lines
87
to
+95
| loading={loading} | ||
| onItemSelect={handleNodeListItemSelect} | ||
| onSearch={handleSearch} | ||
| onClose={onClose} | ||
| onItemHover={onNodeHover} | ||
| renderEmptyState={renderEmptyState} | ||
| searchPlaceholder={ | ||
| searchPlaceholder ?? _({ id: 'addNodePanel.searchNodes', message: 'Search nodes' }) | ||
| } |
Comment on lines
+93
to
+95
| searchPlaceholder={ | ||
| searchPlaceholder ?? _({ id: 'add-node-panel.search-nodes', message: 'Search nodes' }) | ||
| } |
| }: ToolboxProps<T>) { | ||
| const { _ } = useSafeLingui(); | ||
| const searchPlaceholder = _({ id: 'toolbox.search', message: 'Search' }); | ||
| const searchPlaceholder = searchPlaceholderProp ?? _({ id: 'toolbox.search', message: 'Search' }); |
| "sticky-note.toolbar.color": "Color", | ||
| "sticky-note.toolbar.delete": "Delete", | ||
| "sticky-note.toolbar.edit": "Edit", | ||
| "add-node-panel.search-nodes": "Search nodes", |
KodudulaAshishUiPath
force-pushed
the
fix/MST-11831-add-node-search-placeholder
branch
from
2337a94 to
25de34c
Compare
github-actions
Bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddNodePanelnow defaults its search placeholder to "Search nodes" (new lingui messageadd-node-panel.search-nodes).AddNodePanelandToolboxexpose an optionalsearchPlaceholderprop so hosts can pass scoped copy ("Search agents", "Search data nodes") per menu context.Changes
Toolbox: new optionalsearchPlaceholderprop; default behavior unchanged (linguitoolbox.search= "Search"), so other Toolbox consumers (e.g. StageNode) are unaffectedAddNodePanel+AddNodePanel.types: pass-through prop, defaulting to "Search nodes"src/canvas/locales/en.json:add-node-panel.search-nodesentry (English only; translated catalogs land via the usual translator flow), kebab-cased to match the catalog's key conventionTesting
searchPlaceholderprop: Toolbox renders a custom placeholder, AddNodePanel defaults to "Search nodes" and forwards a host overrideturbo run typecheck --filter=@uipath/apollo-reactgreen; biome lint shows only pre-existing warningspnpm run i18n:extractcurrently fails repo-wide on a pre-existing duplicate id in ap-chat (autopilot-chat.error.multiple-fileshas two different default texts) — the catalog entry was added by hand and verified withi18n:compile