Skip to content

fix(ui5-form): truncate long header and group header titles #13868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nnaydenow wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui5-form): truncate long header and group header titles #13868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/main/src/FormTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default function FormTemplate(this: Form) {
{this.hasCustomHeader ?
<slot name="header"></slot>
:
<Title id={`${this._id}-header-text`} level={this.headerLevel}>{this.headerText}</Title>
<Title id={`${this._id}-header-text`} level={this.headerLevel} wrappingType="None">{this.headerText}</Title>
}
</div>
}
Expand Down Expand Up @@ -55,7 +55,7 @@ function groupedItemsLayout(this: Form) {
>
{groupItem.headerText &&
<div class="ui5-form-group-heading">
<Title id={`${groupItem._id}-group-header-text`} level={groupItem.headerLevel} size="H6">{groupItem.headerText}</Title>
<Title id={`${groupItem._id}-group-header-text`} level={groupItem.headerLevel} wrappingType="None" size="H6">{groupItem.headerText}</Title>
</div>
}
{this.accessibleMode === "Edit" ?
Expand Down
6 changes: 6 additions & 0 deletions packages/main/src/themes/Form.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
@import "./FormLayout.css";
@import "./FormItemSpan.css";

* {
box-sizing: border-box;
}

:host {
display: block;
container-type: inline-size;
Expand Down Expand Up @@ -38,12 +42,14 @@
height: var(--_ui5-form-group-heading-height);
line-height: var(--_ui5-form-group-heading-height);
padding-inline-start: 0.25rem;
overflow: hidden;
}

.ui5-form-column {
padding-top: 0.5rem;
padding-bottom: 1rem;
box-sizing: border-box;
min-width: 0;
}

::slotted([ui5-form-group]) {
Expand Down
4 changes: 4 additions & 0 deletions packages/main/src/themes/FormItem.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
break-inside: avoid;
}

* {
box-sizing: border-box;
}

.ui5-form-item-root {
background-color: inherit;
color: inherit;
Expand Down
4 changes: 4 additions & 0 deletions packages/main/src/themes/FormItemSpan.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
* The ratio can be changed via the labelSpan and the emptySpan properties.
*/

* {
box-sizing: border-box;
}

:host {
--ui5-form-item-label-justify-internal: start;
--ui5-form-item-label-padding-internal: 0.625rem 0.25rem 0 0.25rem;
Expand Down
4 changes: 4 additions & 0 deletions packages/main/src/themes/FormLayout.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
* S max-width: 600px - container padding 24px
*/

* {
box-sizing: border-box;
}

/* S - 1 column */
@container (width < 600px) {
.ui5-form-layout {
Expand Down
77 changes: 77 additions & 0 deletions packages/main/test/pages/form/FormTitleTruncation.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
<!DOCTYPE html>
<html>

<head>
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no">
<meta charset="utf-8">
<title>Form Basic</title>
<script src="../%VITE_BUNDLE_PATH%" type="module"></script>
<link rel="stylesheet" type="text/css" href="../styles/FormLayout.css">
</head>

<body>
<ui5-form
header-text="Very long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long form title that should be truncated">
<ui5-form-group
header-text="Very long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long form group title that should be truncated">

<ui5-form-item>
<span slot="labelContent">Label:</span>
<textarea value="textarea"></textarea>
</ui5-form-item>
<ui5-form-item>
<span slot="labelContent">Label:</span>
<textarea value="textarea"></textarea>
</ui5-form-item>
<ui5-form-item>
<span slot="labelContent">Label:</span>
<input value="Input"></input>
</ui5-form-item>
<ui5-form-item>
<span slot="labelContent">Label:</span>
<input value="Input"></input>
</ui5-form-item>
<ui5-form-item>
<span slot="labelContent">Label:</span>
<input value="Input"></input>
</ui5-form-item>
<ui5-form-item>
<span slot="labelContent">Label:</span>
<input value="Input"></input>
</ui5-form-item>
</ui5-form-group>
<ui5-form-group
header-text="Very long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long form group title that should be truncated">
<ui5-form-item>
<span slot="labelContent">Label:</span>
<input value="Input"></input>
</ui5-form-item>
<ui5-form-item>
<span slot="labelContent">Label:</span>
<textarea value="textarea"></textarea>
</ui5-form-item>
<ui5-form-item>
<span slot="labelContent">Label:</span>
<textarea value="textarea"></textarea>
</ui5-form-item>
<ui5-form-item>
<span slot="labelContent">Label:</span>
<textarea value="textarea"></textarea>
</ui5-form-item>
<ui5-form-item>
<span slot="labelContent">Label:</span>
<textarea value="textarea"></textarea>
</ui5-form-item>
<ui5-form-item>
<span slot="labelContent">Label:</span>
<input value="Input"></input>
</ui5-form-item>
<ui5-form-item>
<span slot="labelContent">Label:</span>
<input value="Input"></input>
</ui5-form-item>
</ui5-form-group>
</ui5-form>
</body>

</html>
Loading