Skip to content

fix(ui5-segmented-button): remove aria-roledescription attribute #13867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NHristov-sap wants to merge 5 commits into
base: main
Choose a base branch
from
+29 −19
Open

fix(ui5-segmented-button): remove aria-roledescription attribute #13867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ccd49d
fix(ui5-segmented-button): remove aria-roledescription attribute
NHristov-sap Jul 27, 2026
5e21722
fix(ui5-segmented-button): adapt cypress tests
NHristov-sap Jul 27, 2026
2bf9774
Merge branch 'main' into BL_segbtn_desc
NHristov-sap Jul 27, 2026
5c50ae0
fix(ui5-segmented-button): fix lint errors
NHristov-sap Jul 28, 2026
7d4d4f2
Merge branch 'main' into BL_segbtn_desc
NHristov-sap Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions packages/main/cypress/specs/SegmentedButton.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ describe("SegmentedButton Accessibility", () => {
cy.get("[ui5-segmented-button]")
.shadow()
.find(".ui5-segmented-button-root")
.should("have.attr", "aria-description", SegmentedButton.i18nBundle.getText(SEGMENTEDBUTTON_ARIA_DESCRIBEDBY));
.should("not.have.attr", "aria-description");
});

it("segmented button should have correct aria description when accessibleDescription is set", () => {
Expand All @@ -381,7 +381,7 @@ describe("SegmentedButton Accessibility", () => {
cy.get("[ui5-segmented-button]")
.shadow()
.find(".ui5-segmented-button-root")
.should("have.attr", "aria-description", `${DESCRIPTION} ${SegmentedButton.i18nBundle.getText(SEGMENTEDBUTTON_ARIA_DESCRIBEDBY)}`);
.should("have.attr", "aria-description", DESCRIPTION);
});

it("segmented button should have correct aria description when accessibleDescriptionRef is set", () => {
Expand All @@ -399,7 +399,7 @@ describe("SegmentedButton Accessibility", () => {
cy.get("[ui5-segmented-button]")
.shadow()
.find(".ui5-segmented-button-root")
.should("have.attr", "aria-description", `${DESCRIPTION} ${SegmentedButton.i18nBundle.getText(SEGMENTEDBUTTON_ARIA_DESCRIBEDBY)}`);
.should("have.attr", "aria-description", DESCRIPTION);
});

it("segmented button should have correct aria-multiselectable", () => {
Expand Down Expand Up @@ -504,13 +504,27 @@ describe("SegmentedButtonItem Accessibility", () => {
.eq(0)
.shadow()
.find("li")
.should("have.attr", "aria-description", DESCRIPTION);
.should("have.attr", "aria-description", `${DESCRIPTION} ${SegmentedButtonItem.i18nBundle.getText(SEGMENTEDBUTTON_ARIA_DESCRIBEDBY)}`);

cy.get<SegmentedButtonItem>("@items")
.eq(1)
.shadow()
.find("li")
.should("have.attr", "aria-description", REF_DESCRIPTION);
.should("have.attr", "aria-description", `${REF_DESCRIPTION} ${SegmentedButtonItem.i18nBundle.getText(SEGMENTEDBUTTON_ARIA_DESCRIBEDBY)}`);
});

it("segmented button items should not have aria-roledescription", () => {
cy.mount(
<SegmentedButton>
<SegmentedButtonItem>First</SegmentedButtonItem>
<SegmentedButtonItem>Second</SegmentedButtonItem>
</SegmentedButton>
);

cy.get("[ui5-segmented-button-item]")
.shadow()
.find("li")
.should("not.have.attr", "aria-roledescription");
});

it("should set title attribute to slot text when tooltip is not provided", () => {
Expand Down
14 changes: 8 additions & 6 deletions packages/main/src/SegmentedButton.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ import {
isEscape,
isSpaceShift,
} from "@ui5/webcomponents-base/dist/Keys.js";
import { SEGMENTEDBUTTON_ARIA_DESCRIPTION, SEGMENTEDBUTTON_ARIA_DESCRIBEDBY } from "./generated/i18n/i18n-defaults.js";
import { LIST_ITEM_SELECTED } from "./generated/i18n/i18n-defaults.js";
import announce from "@ui5/webcomponents-base/dist/util/InvisibleMessage.js";
import InvisibleMessageMode from "@ui5/webcomponents-base/dist/types/InvisibleMessageMode.js";
import "./SegmentedButtonItem.js";
import type SegmentedButtonItem from "./SegmentedButtonItem.js";
import SegmentedButtonSelectionMode from "./types/SegmentedButtonSelectionMode.js";
Expand Down Expand Up @@ -240,6 +242,10 @@ class SegmentedButton extends UI5Element {
selectedItems: this.selectedItems,
});

if (target.selected) {
announce(SegmentedButton.i18nBundle.getText(LIST_ITEM_SELECTED), InvisibleMessageMode.Assertive);
}

this._itemNavigation.setCurrentItem(target);

return this;
Expand Down Expand Up @@ -338,11 +344,7 @@ class SegmentedButton extends UI5Element {
}

get ariaDescriptionText() {
return `${(getEffectiveAriaDescriptionText(this) || "")} ${SegmentedButton.i18nBundle.getText(SEGMENTEDBUTTON_ARIA_DESCRIBEDBY)}`.trim();
}

get ariaRoleDescription() {
return SegmentedButton.i18nBundle.getText(SEGMENTEDBUTTON_ARIA_DESCRIPTION);
return getEffectiveAriaDescriptionText(this) || undefined;
}
}

Expand Down
8 changes: 2 additions & 6 deletions packages/main/src/SegmentedButtonItem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
import willShowContent from "@ui5/webcomponents-base/dist/util/willShowContent.js";
import slot from "@ui5/webcomponents-base/dist/decorators/slot-strict.js";
import jsxRenderer from "@ui5/webcomponents-base/dist/renderer/JsxRenderer.js";
import { SEGMENTEDBUTTONITEM_ARIA_DESCRIPTION } from "./generated/i18n/i18n-defaults.js";
import { SEGMENTEDBUTTON_ARIA_DESCRIBEDBY } from "./generated/i18n/i18n-defaults.js";
import type { ISegmentedButtonItem } from "./SegmentedButton.js";
import SegmentedButtonItemTemplate from "./SegmentedButtonItemTemplate.js";

Expand Down Expand Up @@ -205,10 +205,6 @@ class SegmentedButtonItem extends UI5Element implements IButton, ISegmentedButto
@i18n("@ui5/webcomponents")
static i18nBundle: I18nBundle;

get ariaDescription() {
return SegmentedButtonItem.i18nBundle.getText(SEGMENTEDBUTTONITEM_ARIA_DESCRIPTION);
}

constructor() {
super();
}
Expand Down Expand Up @@ -268,7 +264,7 @@ class SegmentedButtonItem extends UI5Element implements IButton, ISegmentedButto
}

get ariaDescriptionText() {
return getEffectiveAriaDescriptionText(this) || undefined;
return `${(getEffectiveAriaDescriptionText(this) || "")} ${SegmentedButtonItem.i18nBundle.getText(SEGMENTEDBUTTON_ARIA_DESCRIBEDBY)}`.trim();
}

get showIconTooltip() {
Expand Down
1 change: 0 additions & 1 deletion packages/main/src/SegmentedButtonItemTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ export default function SegmentedButtonItemTemplate(this: SegmentedButtonItem) {
aria-setsize={this.sizeOfSet}
aria-selected={this.selected}
aria-disabled={this.disabled}
aria-roledescription={this.ariaDescription}
data-sap-focus-ref
onClick={this._onclick}
onKeyUp={this._onkeyup}
Expand Down
1 change: 0 additions & 1 deletion packages/main/src/SegmentedButtonTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ export default function SegmentedButtonTemplate(this: SegmentedButton) {
aria-orientation="horizontal"
aria-description={this.ariaDescriptionText}
aria-label={this.ariaLabelText}
aria-roledescription={this.ariaRoleDescription}
>
<slot></slot>
</ul>
Expand Down
Loading