Skip to content

Prebuild windows arm64 binaries#1879

Open
montyc1999 wants to merge 1 commit into
TryGhost:masterfrom
montyc1999:master
Open

Prebuild windows arm64 binaries#1879
montyc1999 wants to merge 1 commit into
TryGhost:masterfrom
montyc1999:master

Conversation

@montyc1999
Copy link
Copy Markdown

Hey @jonatansberg, I know this repo is officially unmaintained, but I figured I'd try anyway.

This is an easy addition because Github now provides windows-11-arm runners.

Addresses:

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e12a838e-a361-46d6-a9d0-187e48f60da5

📥 Commits

Reviewing files that changed from the base of the PR and between 81c20e1 and 4f57057.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • README.md

Walkthrough

This PR adds Windows ARM64 support to the node-sqlite3 project. The CI workflow matrix is extended with three new build configurations targeting windows-11-arm for Node versions 20, 22, and 24, each configured with ARM64 host and target settings. The README is updated to document the new win32-arm64 prebuilt binary target in the supported platforms list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Prebuild windows arm64 binaries' directly summarizes the main change: adding CI support for building Windows ARM64 binaries via the github workflows and documenting the new target in the README.
Description check ✅ Passed The description clearly relates to the changeset by explaining the motivation (GitHub's windows-11-arm runners) and referencing specific issues being addressed, which aligns with the CI workflow and README updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant