Skip to content

🎨 Removed date-fns dependency - #209

Open
acburdine wants to merge 1 commit into
mainfrom
feat/date-fns-refactor
Open

🎨 Removed date-fns dependency#209
acburdine wants to merge 1 commit into
mainfrom
feat/date-fns-refactor

Conversation

@acburdine

Copy link
Copy Markdown
Member

no ref

  • date-fns is 24mb/2k+ files, pulled in as a dep specifically for add/sub functions
  • because nql uses a limited subset of functionality, we replicate it in-repo rather than pull in the extra dep

note: date-fns makes a lot of sense for tree-shakeable frontend code that's bundled, not so much for server-side code that isn't

@acburdine
acburdine force-pushed the feat/date-fns-refactor branch from ded8e8c to e2b7e77 Compare August 14, 2026 00:11
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@acburdine, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 116 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b9c5fbe3-f295-47dc-86d1-a587a6d5c39a

📥 Commits

Reviewing files that changed from the base of the PR and between e36120f and 3c39d1c.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (4)
  • packages/nql-lang/lib/date-math.js
  • packages/nql-lang/lib/scope.js
  • packages/nql-lang/package.json
  • packages/nql-lang/test/date-math.test.js
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/date-fns-refactor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.78%. Comparing base (e36120f) to head (3c39d1c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   85.39%   85.78%   +0.38%     
==========================================
  Files           9       10       +1     
  Lines        2273     2335      +62     
  Branches      479      492      +13     
==========================================
+ Hits         1941     2003      +62     
  Misses        326      326              
  Partials        6        6              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

no ref
- date-fns is 24mb/2k+ files, pulled in as a dep specifically for add/sub functions
- because nql uses a limited subset of functionality, we replicate it in-repo rather than pull in the extra dep
@acburdine
acburdine force-pushed the feat/date-fns-refactor branch from e2b7e77 to 3c39d1c Compare August 14, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants