Preserve alias hook replacements across no-op callbacks - #1722
Merged
jlarson4 merged 1 commit intoAug 25, 2026
Merged
Conversation
Collaborator
|
Looks great! Thanks @koriyoshi2041 for putting this together |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a hook runs under multiple alias names, each callback sees the previous callback's replacement. However, if a later alias callback returns
None,HookPoint.full_hookreturns that finalNoneand silently discards an earlier replacement. This affects both forward activations and backward gradients.Fix
Track whether any alias callback changed the value and return the accumulated result after all aliases have run. The existing all-no-op behavior remains unchanged.
Test
uv run pytest tests/unit/test_hook_points.py -q— 31 passeduv run black --check transformer_lens/hook_points.py tests/unit/test_hook_points.pyuv run isort --check-only transformer_lens/hook_points.py tests/unit/test_hook_points.pyuv run mypy transformer_lens— 388 source files cleangit diff --checkThe regressions cover forward replacements, conversion reversion, and backward gradient replacements.
Risk
Low. The change is limited to alias dispatch and only changes the returned value when an earlier alias callback supplied a replacement. Canonical hooks and all-
Nonealias chains retain their current behavior.