Skip to content

Remove extra checks from Phi adapter setup_component_testing#1373

Merged
jlarson4 merged 1 commit into
TransformerLensOrg:devfrom
TensorCruncher:remove-extra-checks-from-phi-adapter
Jun 9, 2026
Merged

Remove extra checks from Phi adapter setup_component_testing#1373
jlarson4 merged 1 commit into
TransformerLensOrg:devfrom
TensorCruncher:remove-extra-checks-from-phi-adapter

Conversation

@TensorCruncher

@TensorCruncher TensorCruncher commented Jun 9, 2026

Copy link
Copy Markdown

Description

Remove unnecessary checks for rotary_emb location in Phi adapter setup_component_testing method.

Fixes #1368

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

@TensorCruncher

Copy link
Copy Markdown
Author

I think the one failing test was due to Error 429 from HF

@jlarson4

jlarson4 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

You'd be correct! Happens any time more than 1 PR is submitted around the same time. I am rerunning now

@jlarson4 jlarson4 merged commit d37642d into TransformerLensOrg:dev Jun 9, 2026
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants