fix: use inline x-release-please-version annotation#76
Merged
Conversation
The generic extra-files updater needs the annotation as a trailing inline comment on the version line itself, not a leading comment above it — confirmed against OneLiteFeatherNET/PlayerKits' actually- working config. The leading-comment form silently didn't bump gradle.properties in the open release PR (#75, stuck at 1.4.7 while the manifest/tag moved to 1.4.8). Java .properties syntax only treats '#' as a comment marker at the start of a line, so the inline annotation becomes part of the raw version string ("1.4.7 # x-release-please-version"). Strip it back off in build.gradle.kts before Gradle uses the version anywhere, same substringBefore('#') pattern PlayerKits uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-release-please-versionannotation as a trailing inline comment on the version line itself, not a leading comment above it — confirmed againstOneLiteFeatherNET/PlayerKits' actually-working config.gradle.propertiesin the currently open release PR (chore(main): release 1.4.8 #75), which is stuck at1.4.7while the manifest/tag moved to1.4.8..propertiessyntax only treats#as a comment marker at the start of a line, so once moved inline the annotation becomes part of the rawversionstring ("1.4.7 # x-release-please-version"). Strips it back off inbuild.gradle.ktsbefore Gradle uses the version anywhere — samesubstringBefore('#')pattern PlayerKits uses.Test plan
./gradlew compileJavapasses./gradlew clean shadowJarproducesBlueMapS3Storage-1.4.7.jar(clean version string, no trailing comment leaking into the filename)gradle.propertiesbumped to1.4.8