fix(maths): defer Matrix type annotations so import does not NameError - #15103
Open
sudo-ai-git wants to merge 1 commit into
Open
fix(maths): defer Matrix type annotations so import does not NameError#15103sudo-ai-git wants to merge 1 commit into
sudo-ai-git wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fix a bug in matrix_exponentiation: importing the module raised
NameError: name 'Matrix' is not definedbecause the class method annotations referenceMatrixbefore it is defined (eager annotation evaluation). Addfrom __future__ import annotationsto defer annotation evaluation.Checklist:
Fixes #15075. Verified: import now succeeds,
fibonacci_with_matrix_exponentiation(13,0,1) == 144, doctests pass. Minimal change (add one__future__import line only).