Skip to content

perf(graphs): use deque.popleft() for O(1) queue ops in Kahn's topological sort - #15102

Open
sudo-ai-git wants to merge 1 commit into
TheAlgorithms:masterfrom
sudo-ai-git:fix/kahns-deque-popleft
Open

perf(graphs): use deque.popleft() for O(1) queue ops in Kahn's topological sort#15102
sudo-ai-git wants to merge 1 commit into
TheAlgorithms:masterfrom
sudo-ai-git:fix/kahns-deque-popleft

Conversation

@sudo-ai-git

Copy link
Copy Markdown

Describe your change:

Improve Kahn's topological sort queue operations from O(n) list pop(0) to O(1) deque.popleft().

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python [type hints].
  • All functions have [doctests] that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a [closing keyword]: "Fixes [BUG] Inefficient pop(0) queue operations and IndexError on sparse vertex IDs in graphs/kahns_algorithm_topo.py #15071".

Fixes #15071. vertex = queue.pop(0) on a list is O(n); switching to collections.deque + popleft() makes the BFS queue ops O(1). Doctests pass (4/4); DAG/cycle outputs unchanged. (Note: the sparse-vertex-ID IndexError also noted in #15071 is pre-existing behaviour, present before this change — this PR addresses the pop(0) inefficiency only.)

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Inefficient pop(0) queue operations and IndexError on sparse vertex IDs in graphs/kahns_algorithm_topo.py

1 participant