Skip to content

maths: add Armstrong numbers algorithm#14736

Open
Ayushi-Jain15 wants to merge 4 commits into
TheAlgorithms:masterfrom
Ayushi-Jain15:add-armstrong-numbers
Open

maths: add Armstrong numbers algorithm#14736
Ayushi-Jain15 wants to merge 4 commits into
TheAlgorithms:masterfrom
Ayushi-Jain15:add-armstrong-numbers

Conversation

@Ayushi-Jain15
Copy link
Copy Markdown

Describe your change:

Adds armstrong_numbers.py in the maths directory with two functions:

  • is_armstrong(): checks if a number is an Armstrong number in O(n)
  • get_armstrongs_up_to(): returns all Armstrong numbers up to a given limit
    Both functions include doctests.
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels May 29, 2026
@algorithms-keeper algorithms-keeper Bot removed tests are failing Do not merge until tests pass labels May 29, 2026
Copy link
Copy Markdown

@diusazzad diusazzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed in your checklist that the Wikipedia URL might be missing. TheAlgorithms usually requires at least one reference link (like Wikipedia) in the docstring of the algorithm. Could you just drop a link in there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants