Add Hopcroft-Karp algorithm and doctests for manual_accuracy function#13233
Open
G26karthik wants to merge 6 commits into
Open
Add Hopcroft-Karp algorithm and doctests for manual_accuracy function#13233G26karthik wants to merge 6 commits into
G26karthik wants to merge 6 commits into
Conversation
|
Hi! Can you help me by telling why my build test is failing, I want to contribute search_in_a_rotated_sorted_array in search directory and my build test failed. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new Hopcroft-Karp bipartite matching implementation and adds a docstring with doctests to the existing manual_accuracy function.
Changes:
- New
graphs/hopcroft_karp_matching.pyimplementing Hopcroft-Karp maximum bipartite matching withBipartiteGraphclass. - Adds documentation and doctests for
manual_accuracyinmachine_learning/scoring_functions.py.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| graphs/hopcroft_karp_matching.py | New module implementing Hopcroft-Karp algorithm with BFS/DFS phases and doctests. |
| machine_learning/scoring_functions.py | Adds docstring with examples for manual_accuracy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #9943
Description
This PR includes two contributions:
Hopcroft-Karp Algorithm Implementation: Adds the Hopcroft-Karp algorithm for finding maximum matching in bipartite graphs, a fundamental graph algorithm with O(E√V) time complexity.
Test Coverage Improvement: Adds comprehensive doctests to the
manual_accuracy()function inmachine_learning/scoring_functions.py.Changes
New Algorithm
graphs/hopcroft_karp.pywith full implementationEnhanced Test Coverage
manual_accuracy()Testing