feat: Add NearestElement stack algorithms and fix Javadoc build warnings#7434
Open
sabarirajan83 wants to merge 2 commits into
Open
feat: Add NearestElement stack algorithms and fix Javadoc build warnings#7434sabarirajan83 wants to merge 2 commits into
sabarirajan83 wants to merge 2 commits into
Conversation
Fixed 'documentation comment is not attached to any declaration' errors in: - AnyBaseToAnyBase.java - InterpolationSearch.java - LinearSearch.java These changes ensure build compatibility with modern JDK versions.
sabarirajan83
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
Contributor
prashantpiyush1111
left a comment
prashantpiyush1111
left a comment
There was a problem hiding this comment.
Good implementation overall! Reviewed the NearestElement
stack algorithm. Suggest using ArrayDeque instead of
Stack class for better performance.
| int n = arr.length; | ||
| int[] result = new int[n]; | ||
| Stack<Integer> stack = new Stack<>(); | ||
|
|
Contributor
There was a problem hiding this comment.
Consider using ArrayDeque instead of Stack class,
it is faster and recommended in Java docs.
| // --- Exception Handling --- | ||
|
|
||
| @Test | ||
| void testNullInput() { |
Contributor
There was a problem hiding this comment.
Great test coverage for null input edge case!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces
NearestElement.java, which provides stack-based algorithms to efficiently find the nearest greater or smaller elements in an array (for both left and right directions).EmptyStackException.NearestElementTest.java.Additionally, this PR fixes pre-existing
documentation comment is not attached to any declarationerrors in:AnyBaseToAnyBase.javaInterpolationSearch.javaLinearSearch.javaThese documentation changes ensure strict build compatibility with modern JDK versions (JDK 21+).
Fixes #7322
clang-format -i --style=file path/to/your/file.java