cts: isolate tests from global and detailed placement (#10749)#10769
cts: isolate tests from global and detailed placement (#10749)#10769s-sreedhar wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors several Clock Tree Synthesis (CTS) tests (including buffer_ports, gated_clock4, and hier_insertion_delay) to load pre-placed designs from .odb database files instead of running the entire floorplanning, pin placement, and global/detailed placement steps from scratch. This simplifies the test scripts and reduces the test execution output. I have no feedback to provide as there are no review comments.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to OpenROAD! Thanks for opening your first PR.
Before we review:
- Contribution Guide: https://openroad.readthedocs.io/en/latest/contrib/contributing.html
- Build Instructions: https://openroad.readthedocs.io/en/latest/contrib/BuildWithCMake.html
Please ensure:
- CI passes
- Code is properly formatted
- Tests are included where applicable
A maintainer will review shortly!
|
Rather than use a .odb please use a .def. The odb format changes over time and def is less effort to maintain. |
Okay i ll do that. Thanks |
s-sreedhar
force-pushed
the
cts-isolate-tests
branch
from
8919682 to
2047c76
Compare
|
|
||
| link_design clk_passthrough_top | ||
|
|
||
| read_sdc buffer_ports.sdc |
There was a problem hiding this comment.
you should still read the sdc
| -ver_layers $io_placer_ver_layer | ||
| global_placement -skip_nesterov_place | ||
| detailed_placement | ||
| read_def hier_insertion_delay.def |
There was a problem hiding this comment.
As this is a hierarchical test case you'll need to read a verilog as well as a def.
Signed-off-by: s-sreedhar <s.sreedhargoud@gmail.com>
s-sreedhar
force-pushed
the
cts-isolate-tests
branch
from
2047c76 to
cd5f7c1
Compare
|
I made the changes you have requested. Is every thing okay now? |
2 participants
Summary
This PR isolates several CTS regression tests (
gated_clock4.tcl,hier_insertion_delay.tcl, andbuffer_ports.tcl) by removing unnecessary upstream dependencies on floorplanning and placement (global_placementanddetailed_placement).Instead of dynamically invoking GPL and DPL during the test runs, the tests now load a pre-placed and validated design database (
.odbfile) directly viaread_db. This prevents changes in DPL/GPL (such as minor legalization coordinate differences) from breaking unrelated CTS regression targets and avoids large log maintenance overhead (ref #10749).Type of Change
Impact
No change to OpenROAD tool behavior. Isolates CTS integration tests from upstream placement tool variations and cuts test execution runtime
Verification
./etc/Build.sh).Related Issues
Fixes #10749