Mark non-hermetic targets 'manual'.#10687
Conversation
hzeller
force-pushed
the
feature-20260618-non-hermetic-manual
branch
from
6468664 to
dc1054f
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the "manual" tag to several Bazel targets in BUILD.bazel and docs/BUILD.bazel, including linting and formatting tests, the lint_test test suite, and the man_pages target. This prevents these targets from running automatically during wildcard test executions. There are no review comments, so I have no feedback to provide.
hzeller
force-pushed
the
feature-20260618-non-hermetic-manual
branch
from
dc1054f to
218a438
Compare
They can only run on special machines that have the binaries `git` (for the format tests) or `make` installed AND with their bazel configured to actually look in the path. These targets currently will fail on strict systems (such as NixOS), so make the whole process painful. To fix, the binaries either should be replaced with simpler processes (e.g. why use `make` if we have bazel), or commpiled as part of a bazel dependency. Makes The-OpenROAD-Project#10311 slightly less painful by not failing in globbing mode. Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260618-non-hermetic-manual
branch
from
218a438 to
32a33b7
Compare
|
I don't agree to this direction. These are targets we do want to have run. I think we should try to improve the bazel build rather than dumb it down. |
I agree. I am asking for a month or so to get this fixed, so for now I just want the build to be working until that is resolved. |
|
The build is working on non-NIX platforms. Is it possible to turn this into an opt-out? |
2 participants
They can only run on special machines that have the binaries
git(for the format tests) ormakeinstalled AND with their bazel configured to actually look in the path.These targets currently will fail on strict systems (such as NixOS), so make the whole process painful. To fix, the binaries either should be replaced with simpler processes (e.g. why use
makeif we have bazel), or commpiled as part of a bazel dependency.Makes #10311 slightly less painful by not failing in globbing mode (
bazel build ...).