bugsnag: propagate cloud_provider into contextual logging for queued executions#268
Merged
Merged
Conversation
Collaborator
Author
This was referenced May 28, 2026
morgan-wowk
force-pushed
the
bugsnag/cloud-provider-context
branch
from
65d8571 to
3bb4cc1
Compare
Collaborator
Author
|
CC: @yuechao-qin This will allow you to filter errors to Nebius or GKE. |
morgan-wowk
force-pushed
the
bugsnag/cloud-provider-context
branch
from
3bb4cc1 to
faed3ca
Compare
morgan-wowk
force-pushed
the
bugsnag/service-slice
branch
from
abe0fb0 to
4730f88
Compare
morgan-wowk
force-pushed
the
bugsnag/cloud-provider-context
branch
2 times, most recently
from
a2974f3 to
410f807
Compare
Mbeaulne
reviewed
Jun 4, 2026
Mbeaulne
reviewed
Jun 4, 2026
Mbeaulne
reviewed
Jun 4, 2026
Mbeaulne
reviewed
Jun 4, 2026
yuechao-qin
previously requested changes
Jun 8, 2026
|
|
||
| from .. import backend_types_sql as bts | ||
|
|
||
| _CLOUD_PROVIDER_ANNOTATION_KEY = "cloud-pipelines.net/orchestration/cloud_provider" |
Collaborator
There was a problem hiding this comment.
nebius_launchers.py has this same exact constant. Would it make sense to create a shared config/model/etc file that both of them reference against? Or some way to not duplicate the variable?
Collaborator
Author
There was a problem hiding this comment.
🤖 Good eye, but the duplication is intentional for now. The tech lead asked us not to commit CLOUD_PROVIDER_ANNOTATION_KEY to the shared common_annotations layer yet — there's an open question about whether a launcher-specific annotation is the right long-term standard, or whether a different annotation design would be better. Once there's consensus, we can consolidate. Until then, keeping it private to each module avoids prematurely locking in the API.
morgan-wowk
force-pushed
the
bugsnag/service-slice
branch
from
4730f88 to
e6a36dc
Compare
morgan-wowk
force-pushed
the
bugsnag/cloud-provider-context
branch
from
410f807 to
f313191
Compare
Mbeaulne
approved these changes
Jun 12, 2026
Ark-kun
approved these changes
Jun 12, 2026
Collaborator
Author
|
Smoke-tested E2E locally. |
Collaborator
Author
Merge activity
|
morgan-wowk
changed the base branch from
bugsnag/service-slice
to
graphite-base/268
…executions Adds CLOUD_PROVIDER_ANNOTATION_KEY to common_annotations so the annotation key has a single definition in the OSS layer. In the queued-execution processing span, reads the cloud_provider value from task_spec annotations (already in memory) and adds it to the contextual logging context when present. The existing _before_notify hook then includes it automatically in the tangle_context tab on every Bugsnag event raised during that execution's processing.
morgan-wowk
force-pushed
the
bugsnag/cloud-provider-context
branch
from
f313191 to
964652e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.