Skip to content

fix(solid-query): expose deferred SSR query errors #11060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ckdwns9121 wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −0
Open

fix(solid-query): expose deferred SSR query errors #11060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/settled-ssr-state.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/solid-query': patch
---

Expose settled query state when rendering deferred queries during SSR.
10 changes: 10 additions & 0 deletions packages/solid-query/src/useBaseQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,16 @@ export function useBaseQuery<
target: QueryObserverResult<TData, TError>,
prop: keyof QueryObserverResult<TData, TError>,
): any {
// The server subscriber resolves the resource without updating `state`.
// Read the settled resource so deferred SSR renders do not stay frozen
// on the initial optimistic result.
if (isServer) {
const resolved = queryResource()
if (resolved && prop in resolved) {
return Reflect.get(resolved, prop)
}
}

if (prop === 'data') {
if (state.data !== undefined) {
return queryResource.latest?.data
Expand Down