fix: undo strict null widening for tool inputs#939
Draft
jan-kubica wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
OpenAI-compatible strict function schemas promote optional properties to required nullable properties. The model can therefore return
nullfor an omitted optional field, but TanStack AI subsequently validates that value against the original Standard Schema, where.optional()accepts absence/undefined, notnull. This prevents otherwise valid server tools from executing.This PR:
NullWideningMapduring the same OpenAI strict-schema conversion that adds nullabilityTest plan
pnpm run test:prpnpm --filter @tanstack/openai-base test:lib(134 tests)pnpm --filter @tanstack/ai-e2e test:e2e -- openai-strict-tool-null-wire.spec.tspnpm --filter @tanstack/ai-e2e test:e2e(347 passed, 2 unrelated flaky tests passed on retry, 1 gated live smoke skipped)✅ Checklist
pnpm run test:pr.🚀 Release Impact