Skip to content

refactor: split ThumbRenderer class #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CyanVoxel wants to merge 8 commits into
base: main
Choose a base branch
from
Open

refactor: split ThumbRenderer class #1462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
068add2
refactor: split ThumbRenderer class
CyanVoxel Jul 25, 2026
8995ef6
refactor: consolidate embedded archive thumbnail functions
CyanVoxel Jul 25, 2026
d2bf445
fix: move jxl optional import to raster_image.py
CyanVoxel Jul 25, 2026
0c21c45
refactor: name and license consistency, misc fixes
CyanVoxel Jul 25, 2026
cd6e427
fix: remove file_renderer.py
CyanVoxel Jul 25, 2026
e2c9d30
refactor: split Qt functions from thumb renderer
CyanVoxel Jul 26, 2026
e050fc0
refactor: cleanup vendored blender file
CyanVoxel Jul 26, 2026
ef94c6f
refactor: rename ambiguous variables
CyanVoxel Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ filterwarnings = [
ignore = [
".venv/**",
"src/tagstudio/core/library/json/",
"src/tagstudio/qt/previews/vendored/pydub/",
"src/tagstudio/renderers/vendored/pydub/",
]
include = ["src/tagstudio", "tests"]
# Reference for the settings here: https://github.com/microsoft/pyright/blob/main/docs/configuration.md
Expand Down Expand Up @@ -117,7 +117,7 @@ ignore = ["D100", "D101", "D102", "D103", "D104", "D105", "D106", "D107"]

[tool.ruff.lint.per-file-ignores]
"tests/**" = ["D", "E402"]
"src/tagstudio/qt/previews/vendored/**" = ["B", "E", "N", "UP", "SIM115"]
"src/tagstudio/renderers/vendored/**" = ["B", "E", "N", "UP", "SIM115"]

[tool.ruff.lint.pydocstyle]
convention = "google"
1 change: 1 addition & 0 deletions src/tagstudio/core/media_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@ class MediaCategories:
".nef",
".nrw",
".orf",
".r3d",
".raf",
".raw",
".rw2",
Expand Down
8 changes: 2 additions & 6 deletions src/tagstudio/qt/helpers/file_tester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import ffmpeg

from tagstudio.qt.previews.vendored.probe import probe
from tagstudio.renderers.vendored.probe import probe


def is_readable_video(filepath: Path | str):
Expand All @@ -23,11 +23,7 @@ def is_readable_video(filepath: Path | str):
return False
for stream in result["streams"]:
# DRM check
if stream.get("codec_tag_string") in [
"drma",
"drms",
"drmi",
]:
if stream.get("codec_tag_string") in ["drma", "drms", "drmi"]:
return False
except ffmpeg.Error:
return False
Expand Down
Loading
Loading