build(plugins): bump PluginKit ABI to 17 for SSLHandshakeError transfer-type change#1521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1520.
Why
#1520 added three cases to
SSLHandshakeError, which is a PluginKit transfer type, but did not bumpcurrentPluginKitVersion(it was treated as a non-protocol change).TableProPluginKitis built without library evolution, so the enum's binary layout is fixed at compile time, and the plugin load gate is an exact-match oncurrentPluginKitVersion.With the version left at 16, the old released app (7-case enum) and the new app (10-case enum) both report 16. A Cassandra plugin rebuilt from current
mainand published at 16 would be loaded by an old app, and throwing one of the new cases (clientKeyInvalidand friends) into the old app's 7-case enum binary traps on an unexpected enum value. That is the exact SSL error path #1520 set out to improve.What
currentPluginKitVersion16 -> 17 inPluginManager.swift.TableProPluginKitVersion16 -> 17 in all 21 pluginInfo.plistfiles.Bundled plugins ship with the next app release. After this merges, registry plugins get re-released at 17 with
scripts/release-all-plugins.sh 17; the registry keeps the last two kit versions, so users on the previous app still receive the compatible 16 binaries.No user-facing behavior change, so no CHANGELOG entry.