Skip to content

docs(claude-md): strengthen testing requirements and add UI test command#1465

Open
J2TeamNNL wants to merge 4 commits into
TableProApp:mainfrom
J2TeamNNL:docs/update-testing-rules
Open

docs(claude-md): strengthen testing requirements and add UI test command#1465
J2TeamNNL wants to merge 4 commits into
TableProApp:mainfrom
J2TeamNNL:docs/update-testing-rules

Conversation

@J2TeamNNL
Copy link
Copy Markdown
Contributor

Summary

These are project-convention changes that affect every future PR.

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution! Before we can merge this PR, you need to sign our Contributor License Agreement.

To sign, please comment below with:

I have read the CLA Document and I hereby sign the CLA.


I have read the CLA Document and I hereby sign the CLA.


1 out of 2 committers have signed the CLA.
✅ (J2TeamNNL)[https://github.com/J2TeamNNL]
@claude
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7271232286

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread CLAUDE.md
xcodebuild -project TablePro.xcodeproj -scheme TablePro test -skipPackagePluginValidation
xcodebuild -project TablePro.xcodeproj -scheme TablePro test -skipPackagePluginValidation -only-testing:TableProTests/TestClassName
xcodebuild -project TablePro.xcodeproj -scheme TablePro test -skipPackagePluginValidation -only-testing:TableProTests/TestClassName/testMethodName
xcodebuild -project TablePro.xcodeproj -scheme TablePro test -skipPackagePluginValidation -only-testing:TableProUITests
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Point the UI test command at an existing target

In this repo the new command selects TableProUITests, but I inspected TablePro.xcodeproj/project.pbxproj and TablePro.xcodeproj/xcshareddata/xcschemes/TablePro.xcscheme, and the only test target/testable is TableProTests. Apple documents -only-testing identifiers as being rooted at the test target (test_target/test_type/test_function), so this command cannot run a valid bundle here and will fail for anyone following the added UI-test guidance until a TableProUITests target is added or the command is removed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants