1627 facilities in nav bar menu - #1628
Conversation
with the new AppConfig.observation_facilities() integration point. So, facility.get_service_classes collects facilities from the new integration point and `settings.TOM_FACILITY_CLASSES` combined.
phycodurus
changed the title
jchate6
left a comment
jchate6
left a comment
There was a problem hiding this comment.
Resolving this issue would greatly help with the review of this PR.
TOMToolkit/tom_demoapp#30
jchate6
left a comment
jchate6
left a comment
There was a problem hiding this comment.
The comments and doc strings need to be cleaned up.
Many of the tests are not useful and just more code that needs to be maintained.
We should not rely on a URL in the app config. Just pass this information from the class.
this is better than having it be an integration point dictionary item
in anticipation of Facility model with list- and detail views
This way we response to CSS_THEME over rides like everyone else.
|
@jchate6 this is ready for review. The major change since that last review is moving the facility detail page url from the integration point config to the Facility class itself. An updated tom_demoapp PR is next (and that should help evaluate this PR). |
2 participants
Adds integration point (
AppConfig.observation_facilities()which is analogous to thedata_services()integration point) for facilities with general, non-Target-specific functionality that should be presented on a "facility" index page (not a TargetDetail page, b/c it's not specific to a Target). Facilities that implement the integration point:Closes